User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101
            Thunderbird/24.5.0
MIME-Version: 1.0
References: <5367BB2E.1010403@nag.co.uk> <j39taff9cl0n.dlg@nililand.de>        
            <536B7DD6.2010905@nag.co.uk> <nuxaak153kin$.dlg@nililand.de>
Content-Type: multipart/alternative; boundary="------------090305060801020002080801"
Received-SPF: None (: nag.co.uk does not designate permitted sender hosts)
Message-ID:  <536BAC64.8020700@nag.co.uk>
Date:         Thu, 8 May 2014 17:10:12 +0100
Reply-To: Mailing list for the LaTeX3 project
              <LATEX-L@LISTSERV.UNI-HEIDELBERG.DE>
Sender: Mailing list for the LaTeX3 project <LATEX-L@LISTSERV.UNI-HEIDELBERG.DE>
From: David Carlisle <davidc@NAG.CO.UK>
Subject: Re: New LaTeX2e Release 2014/05/01 : Serious bug in keyval?
To: LATEX-L@LISTSERV.UNI-HEIDELBERG.DE
In-Reply-To:  <nuxaak153kin$.dlg@nililand.de>
Precedence: list
Envelope-To: <rainer.schoepf@GMX.NET>
Status: R

--------------090305060801020002080801
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit

On 08/05/2014 17:00, Ulrike Fischer wrote:


> I tested a bit with various  files and it seems ok. But -- as the
 > question on tex.sx shows -- the bug didn't always lead to errors but
 > could simply produce faulty output and it is not so easy to check if
 > somewhere an "and" or a comma is missing

Thanks.

  With this change reverted the only remaining change is adding \long 
everywhere
so there shouldn't be any change other than things that were error 
before are now allowed.
(Although code that is explicitly checking a definition with \patchcmd or
\checkcommand etc can of course fail if _any_ change is made such 
failures are usually pretty obvious though.


> If one loads the new xkeyval  v2.6c before keyval the error is still
 > there. So xkeyval needs a patch too.

Yep it's an identical patch needed (in xkeyval's keyval.tex and xkeyval.tex)
Sorry to Hendri Adriaens (I gave him a prerelease of keyval and 
suggested he update to
match) I was just holding off until I have confirmed this is OK before 
suggesting xkeyval is changed again.

David


$ diff /usr/local/texlive/2014/texmf-dist/tex/generic/xkeyval/keyval.tex .
48c48
< \long\def\KV@@sp@b#1##1 \@nil{\KV@@sp@c\@empty##1}%
---
 > \long\def\KV@@sp@b#1##1 \@nil{\KV@@sp@c##1}%
51c51
< 
\long\def\KV@@sp@c#1\@nil#2\relax#3{\XKV@toks\expandafter{#1}\edef#3{\the\XKV@toks}}
---
 > \long\def\KV@@sp@c#1\@nil#2\relax#3{\XKV@toks{#1}\edef#3{\the\XKV@toks}}


$ diff /usr/local/texlive/2014/texmf-dist/tex/generic/xkeyval/xkeyval.tex .
786c786
<   \XKV@r@placepointers\@empty#1\usevalue\@nil
---
 >   \XKV@r@placepointers#1\usevalue\@nil
789c789
< \expandafter\XKV@addtomacro@n\expandafter\XKV@tempa\expandafter{#1}%
---
 >   \XKV@addtomacro@n\XKV@tempa{#1}%


________________________________________________________________________
The Numerical Algorithms Group Ltd is a company registered in England
and Wales with company number 1249803. The registered office is:
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.

This e-mail has been scanned for all viruses by Star. The service is
powered by MessageLabs. 
________________________________________________________________________
--------------090305060801020002080801
Content-Type: text/html; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    On 08/05/2014 17:00, Ulrike Fischer wrote:<br>
    <br>
    <br>
    <span style="white-space: pre;">&gt; I tested a bit with various
      files and it seems ok. But -- as the <br>
      &gt; question on tex.sx shows -- the bug didn't always lead to
      errors but <br>
      &gt; could simply produce faulty output and it is not so easy to
      check if <br>
      &gt; somewhere an "and" or a comma is missing</span><br>
    <br>
    Thanks.<br>
    <br>
    &nbsp;With this change reverted the only remaining change is adding \long
    everywhere<br>
    so there shouldn't be any change other than things that were error
    before are now allowed.<br>
    (Although code that is explicitly checking a definition with
    \patchcmd or<br>
    \checkcommand etc can of course fail if _any_ change is made such
    failures are usually pretty obvious though.<br>
    <br>
    <br>
    <br>
    <span style="white-space: pre;">&gt; If one loads the new xkeyval
      v2.6c before keyval the error is still <br>
      &gt; there. So xkeyval needs a patch too.</span><br>
    <br>
    Yep it's an identical patch needed (in xkeyval's keyval.tex and
    xkeyval.tex)<br>
    Sorry to Hendri Adriaens (I gave him a prerelease of keyval and
    suggested he update to<br>
    match) I was just holding off until I have confirmed this is OK
    before suggesting xkeyval is changed again.<br>
    <br>
    David<br>
    <br>
    <br>
    <br>
    $ diff
    /usr/local/texlive/2014/texmf-dist/tex/generic/xkeyval/keyval.tex .<br>
    48c48<br>
    &lt; \long\def\KV@@sp@b#1##1 \@nil{\KV@@sp@c\@empty##1}%<br>
    ---<br>
    &gt; \long\def\KV@@sp@b#1##1 \@nil{\KV@@sp@c##1}%<br>
    51c51<br>
    &lt;
\long\def\KV@@sp@c#1\@nil#2\relax#3{\XKV@toks\expandafter{#1}\edef#3{\the\XKV@toks}}<br>
    ---<br>
    &gt;
    \long\def\KV@@sp@c#1\@nil#2\relax#3{\XKV@toks{#1}\edef#3{\the\XKV@toks}}<br>
    <br>
    <br>
    $ diff
    /usr/local/texlive/2014/texmf-dist/tex/generic/xkeyval/xkeyval.tex .<br>
    786c786<br>
    &lt;&nbsp;&nbsp; \XKV@r@placepointers\@empty#1\usevalue\@nil<br>
    ---<br>
    &gt;&nbsp;&nbsp; \XKV@r@placepointers#1\usevalue\@nil<br>
    789c789<br>
    &lt;&nbsp;&nbsp;
    \expandafter\XKV@addtomacro@n\expandafter\XKV@tempa\expandafter{#1}%<br>
    ---<br>
    &gt;&nbsp;&nbsp; \XKV@addtomacro@n\XKV@tempa{#1}%<br>
    <br>
    <br>
    <br>
    <br>
  <br clear="both">
________________________________________________________________________<BR>
The Numerical Algorithms Group Ltd is a company registered in England<BR>
and Wales with company number 1249803. The registered office is:<BR>
Wilkinson House, Jordan Hill Road, Oxford OX2 8DR, United Kingdom.<BR>
<BR>
This e-mail has been scanned for all viruses by Star. The service is<BR>
powered by MessageLabs. <BR>
________________________________________________________________________<BR>
</body>
</html>


--------------090305060801020002080801--