Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1081)
References: <C58398B6-8915-458C-AF38-F3C82F9342B2@gmail.com>                   
            <4E4FF538.7070601@morningstar2.co.uk>           
            <9788A2B7-3E8F-4D2C-A52E-10999BCB59FA@gmail.com>           
            <4E516DF2.4040002@morningstar2.co.uk>           
            <104nbkj0nr84x.dlg@nililand.de>           
            <4E523217.2080408@morningstar2.co.uk>
            <cybpko27uiip.dlg@nililand.de> <4E52AA87.6090608@morningstar2.co.uk>
Content-Transfer-Encoding: 8bit
Message-ID:  <CE2EDDD0-F481-4D40-A01C-501E2AD2CF9A@gmail.com>
Date:         Tue, 23 Aug 2011 15:13:55 +0930
Reply-To: Mailing list for the LaTeX3 project
              <LATEX-L@listserv.uni-heidelberg.de>
Sender: Mailing list for the LaTeX3 project <LATEX-L@listserv.uni-heidelberg.de>
From: Will Robertson <wspr81@GMAIL.COM>
Subject: Re: couple of l3keys notes
To: LATEX-L@listserv.uni-heidelberg.de
In-Reply-To:  <4E52AA87.6090608@morningstar2.co.uk>
Precedence: list
Status: R

On 23/08/2011, at 4:44 AM, Joseph Wright wrote:

> I have added the scheme broadly as outlined above to l3keys. Feedback
> would be welcome. For example, does 'set_known' convey the appropriate
> idea? Show the variable used for storing the 'return' value be fixes, or
> flexible as in
> 
>  \keys_set_known:nnN { <module> } { <keys> } <return-var>


I slightly prefer having an explicit <return-var>. Not only is the resultant code a little clearer (using, say, \l_fontspec_features_tl instead of \l_keys_leftovers_tl) but also allows some interleaving where you otherwise might have to manually push/pop the value of \l_keys_leftovers_tl.

Cheers,
-- Will