References: <85wsoeto1k.fsf@lola.goethe.zz>
            <18385.42387.268037.81145@morse.mittelbach-online.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Message-ID:  <851w6mtgar.fsf@lola.goethe.zz>
Date:         Fri, 7 Mar 2008 21:44:44 +0100
Reply-To: Mailing list for the LaTeX3 project
              <LATEX-L@LISTSERV.UNI-HEIDELBERG.DE>
Sender: Mailing list for the LaTeX3 project <LATEX-L@LISTSERV.UNI-HEIDELBERG.DE>
From: David Kastrup <dak@GNU.ORG>
Subject: Re: A really, really bad bug.
To: LATEX-L@LISTSERV.UNI-HEIDELBERG.DE
In-Reply-To:  <18385.42387.268037.81145@morse.mittelbach-online.de> (Frank
              Mittelbach's message of "Fri, 7 Mar 2008 21:29:07 +0100")
Precedence: list
Status: R

--=-=-=

Frank Mittelbach <frank.mittelbach@LATEX-PROJECT.ORG> writes:

> well, you seem to be the first person getting into trouble with this,
> but that doesn't mean one shouldn't fix it.

5000 labels is easy to reach if you are using the label mechanism
extensively.

> I don't really mind either of the three solutions (provided none of
> the kills the regression tests for 2e) but personally I would simply
> drop the group unless somebody can give me a good reason why it could
> be needed in a certain situation.

Other code checking the definition of the current label?  Or something?
No idea.  Maybe to keep the effect of \tmpswawhatever local?

Otherwise, here is what I would propose (since it mimics a definition
elsewhere with regard to label save stack buildup in ltxref.dtx).


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment

diff --git a/base/ltmiscen.dtx b/base/ltmiscen.dtx
index 40f283c..b2d35c0 100644
--- a/base/ltmiscen.dtx
+++ b/base/ltmiscen.dtx
@@ -263,9 +263,9 @@
 %
 % \begin{macro}{\@testdef}
 %    \begin{macrocode}
-\def\@testdef #1#2#3{%
+\def\@testdef #1#2#3{{%
   \def\reserved@a{#3}\expandafter \ifx \csname #1@#2\endcsname
- \reserved@a  \else \@tempswatrue \fi}
+ \reserved@a  \else \aftergroup\@tempswatrue \fi}}
 %    \end{macrocode}
 %  \end{macro}
 %

--=-=-=


The "only" problem with that is that it breaks Babel (which checks for
the old definition).  Babel can be fixed in the obvious way by checking
for the changed definition and changing its own replacement.

However, BABEL IS NOT IN THE SVN REPOSITORY AND DISTRIBUTED SEPARATELY.
ARRRRGHH!!!!!

Obviously, the change needs to be made simultaneously.  PLEASE, PLEASE,
PLEASE, Johannes, can you submit Babel to the LaTeX repository or send
your repo to somebody who can?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

--=-=-=--